feat(@schematics/angular): add --standalone to ng generate#23032
Merged
Conversation
|
Isn't this a duplicate of #23024 |
Member
Author
|
I picked this up from Alex. |
crisbeto
added
action: review
crisbeto
force-pushed
the
standalone-schematics
branch
from
4f3f2e7 to
717d64b
Compare
crisbeto
commented
Apr 24, 2022
crisbeto
force-pushed
the
standalone-schematics
branch
from
717d64b to
e323467
Compare
clydin
requested changes
Apr 26, 2022
| "type": "boolean", | ||
| "default": false, | ||
| "alias": "sa", | ||
| "x-user-analytics": 10 |
Member
There was a problem hiding this comment.
Is standalone component generation something we want to track with analytics? If so 15 appears to be the only free slot currently.
/cc @mgechev
crisbeto
force-pushed
the
standalone-schematics
branch
from
e323467 to
267cd19
Compare
Member
Author
|
I've addressed the feedback. |
Adds the `--standalone` flag when generating components, directives or pipes through `ng generate`.
crisbeto
force-pushed
the
standalone-schematics
branch
from
267cd19 to
19f3d3b
Compare
Member
|
From the doc (https://github.com/angular/angular-cli/blob/master/docs/design/analytics.md#list-of-all-dimensions), it appears that there are only 20 allowed and number 15 was the only unused value. |
mgechev
approved these changes
Apr 27, 2022
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
--standaloneflag when generating components, directives or pipes throughng generate.